Zoom out: e2e test - zoomed out mode zooms the canvas #65943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
commented
Oct 8, 2024
MaggieCabrera
added
[Feature] Zoom Out
[Package] E2E Tests
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
talldan
reviewed
Oct 8, 2024
talldan
approved these changes
Oct 8, 2024
This was referenced Oct 9, 2024
talldan
approved these changes
Oct 10, 2024
Comment on lines
42
to
54
| //We use border to separate the content from the frame so we need | ||
| //to check that that is present too, since boundingBox() | ||
| //includes the border to calculate the position | ||
| const borderWidths = await html.evaluate( ( el ) => { | ||
| const styles = window.getComputedStyle( el ); | ||
| return { | ||
| top: parseFloat( styles.borderTopWidth ), | ||
| right: parseFloat( styles.borderRightWidth ), | ||
| bottom: parseFloat( styles.borderBottomWidth ), | ||
| left: parseFloat( styles.borderLeftWidth ), | ||
| }; | ||
| } ); | ||
| expect( htmlRect.y + borderWidths.top ).toBeGreaterThan( iframeRect.y ); |
There was a problem hiding this comment.
I saw that a change was just merged to switch this to padding - https://github.com/WordPress/gutenberg/pull/66012/files
If only top is used, maybe the other sides don't need to be returned from the evaluate callback.
There was a problem hiding this comment.
we are actually changing that right now, so yeah, I'll update once we have a final solution for that
There was a problem hiding this comment.
I updated this to use padding. It seems a bit brittle that the e2e test is dependent on implementation, but I can't think of a better way to test this
There was a problem hiding this comment.
I am merging this now and we can revisit if we found a better way to check for the spacing
Co-authored-by: Daniel Richards <[email protected]>
MaggieCabrera
force-pushed
the
enable-zoom-out-e2e-tests
branch
from
39b3470 to
79aacfb
Compare
ciampo
pushed a commit
that referenced
this pull request
Oct 14, 2024
* removed outdated e2 tests and added a new one * Update test/e2e/specs/site-editor/zoom-out.spec.js Co-authored-by: Daniel Richards <[email protected]> * fixed canvas selector * check the size of the iframe after scaling * check if the canvas is separated * reformat comments * updated test after rebasing trunk with latest changes * recalculate the position using padding instead of border --------- Co-authored-by: Daniel Richards <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: talldan <[email protected]>
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* removed outdated e2 tests and added a new one * Update test/e2e/specs/site-editor/zoom-out.spec.js Co-authored-by: Daniel Richards <[email protected]> * fixed canvas selector * check the size of the iframe after scaling * check if the canvas is separated * reformat comments * updated test after rebasing trunk with latest changes * recalculate the position using padding instead of border --------- Co-authored-by: Daniel Richards <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: talldan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #65797
Why?
We didn't have any e2e tests for zoom out mode
How?
This one removes the skip for zoom out mode tests and replaces the outdated test with a new one. I will follow up with more PRs from the list in Part of #65797
Testing Instructions
Run
npm run test:e2e -- site-editor/zoom-out.spec.jsand the tests should pass