Post Editor: Always force iframe in pattern editor #65887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +21 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c82a629. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11189817035
|
|
I agree this should be fixed. It’s great you spotted the bug.
It’s not clear to me why the conditions can’t already be aggregated there. The hook already checks the post type. I guess maybe the idea is that the hook is Post editor specific yet we want the change to apply in any editor? However for the Site editor it doesn’t seem possible for the canvas to not be iframed. In the widgets editor it seems pattern insertion isn’t allowed so pattern editing is also not possible. |
|
I've tried consolidating all the conditions into the
That's a good point. The widget editor doesn't allow us to create patterns from blocks. Even if you copy and paste a sync pattern from the post editor, it doesn't do anything because
Perhaps there are hurdles to overcome before we can add patterns to the widget editor. Related issues: |
This reverts commit 5da8433.
The E2E test failure does not appear to be caused by the integration. I will try restoring the commit again at a later date. Update: The test failure was fixed in #65939, so I committed the condition integration again. |
stokesman
reviewed
Oct 16, 2024
Comment on lines
-361
to
-364
| const shouldIframe = | ||
| ! disableIframe || [ 'Tablet', 'Mobile' ].includes( deviceType ); |
There was a problem hiding this comment.
When I first commented, I wasn’t understanding you meant to remove the conditions here but it does make sense to me now. Still, it looks like the tablet and mobile conditions got left out of the post editor’s useShouldIframe hook. I tested and the device previews weren’t working from a non-iframe starting point.
There was a problem hiding this comment.
Sorry, in my repeated commits I seem to have forgotten to update the useShouldIframe hook. It should work as expected now.
|
Thanks for the review! The conflict has been resolved. |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Post Editor: Always force iframe in pattern editor * Aggregate conditions into useShouldIframe hook * Revert "Aggregate conditions into useShouldIframe hook" This reverts commit 5da8433. * Aggregate conditions into useShouldIframe hook * Add device type check to useShouldIframe check Co-authored-by: t-hamano <[email protected]> Co-authored-by: stokesman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while reviewing #65885
What?
In the post editor, force the pattern editor to always be an iframe, regardless of whether the main editor is an ifarme or not. This will make the pattern editor's height fit its content.
Why?
Whether the pattern editor in the post editor is an iframe or not is determined by whether the main editor is an iframe or not.
However, the pattern editor is a resizable editor and the editor height is expected to fit the content. Additionally, the padding appender (the functionality that adds a new block when you click below the last block) is not expected to be used with the pattern editor.
Therefore, if the main editor is not an iframe, clicking below the content in the pattern editor does nothing.
How?
Add a post type check.
However, changing the conditions that determine if it should be an iframe in a lower component (
VisualEditor) may not be ideal - whether it should be an iframe or not is something the post editor should only care about. In the future, it may be possible to aggregate these conditions at a higher layer (useShouldIframe()hook).Update: I consolidated all the conditions that determine whether to run an iframe or not into the useShouldIframe hook.
Testing Instructions