Inserter: Always show the list of all patterns in the inserter #65611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
oandregal,
talldan,
jameskoster,
richtabor,
glendaviesnz and
ellatrix
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
23 tasks
|
Size Change: +401 B (+0.02%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Let's watch for performance degradation here. The pattern parsing is expensive, and we already have reports related to the Inserter + Patterns - #64732. |
|
This should actually make things more performance, because the pattern parsing is only done on the callback to insert. |
richtabor
approved these changes
Sep 24, 2024
|
Much nicer ❤️ |
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #60021
Follow-up to #65490
Similar to #62169 but for patterns
What?
In #62169 we updated the block inserter to show the full block list in the inserter regardless of whether we are allowed or not to insert the block in a given position.
The current PR does the same for patterns. So all patterns are always shown in the inserter but only when you click a pattern, we compute the insertion point for the pattern and insert into the closest available position.
This behavior is very important for the new "select mode" where users will keep adding patterns and selecting sections.
Testing Instructions
1- Add a group with some paragraphs within it
2- Switch to "edit mode" (or select mode)
3- Notice the patterns inserter always shows the full list of patterns regardless of whether a content block is selected or a section.
4- Notice that it always insert after the current section.