Make pattern preview click area larger #61250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jameskoster
added
[Type] Enhancement
jasmussen
approved these changes
Apr 30, 2024
|
Size Change: +11 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Apr 30, 2024
I wish that were the case, but it doesn't work because the element inside fills the space and has a background/fill, so the shadow is obscured. To re-iterate, the purpose of the outline is to ensure clarity about the thumbnail boundaries when the contents has a white backgorund. If you have another idea please feel free to push! It would be nice to remove the pseudo-element if possible. |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make the full pattern preview thumbnail clickable so that it's easier to select smaller patterns
Why?
Fix a regression in #61159.
Before
before.mp4
After
after.mp4
To test