Add stylelint rule to disallow the order CSS property
#61243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Focus] Accessibility (a11y)
afercia
requested review from
ajitbohra,
tellthemachines,
ellatrix,
artemiomorales and
michalczaplinski
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Note: this PR touches two files in the |
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
|
@WordPress/gutenberg-core I'd appreciate a review, when you have a chance 🙇🏽♂️ |
SergeyBiryukov
approved these changes
May 14, 2024
|
WFM |
SergeyBiryukov
approved these changes
May 14, 2024
|
Thanks all for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61241
What?
This PR aims to prevent the usage of the
orderCSS property.Why?
The
orderCSS property has a significant impact on accessibility and its usage must be prevented. In the very rare cases where its usage is appropriate, that should be a conscious choice of contributors and they should be required to add a disable comment with a disable reason.How?
orderCSS property to theproperty-disallowed-listrule.Avoid the order property. For accessibility reasons, visual, reading, and DOM order must match. Only use the order property when it does not affect reading order, meaning, and interactionstylelint-disable*comments by addint the config"reportDescriptionlessDisables": true.Testing Instructions
npm run lint:cssin your terminal, in the project root.order: 1;.npm run lint:cssagain.stylelint-disablecomments are meaningful and appropriate.Testing Instructions for Keyboard
Screenshots or screencast