Group templates in sidebar list #57711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
mcsf,
youknowriad,
mtias,
jameskoster,
richtabor and
annezazu
|
Size Change: +552 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ntsekouras
added
[Type] Enhancement
|
I installed the Sensei LMS plugin, which installs WooCommerce as well. This is what I see: Gravacao.do.ecra.2024-01-10.as.11.34.45.movFeedback:
|
|
If our objective is to replace the current templates sidebar with the templates data view (list layout) for 6.5 then we might want to rethink the design a bit here since we have some new affordances to consider. For instance we might bundle views that filter by author (or allow plugins to register such views): 
Another option – closer to the original design (and this PR) but probably more work – would be to add a 'Group by' view option to data views. This has always been on the radar, but wasn't part of the original spec because we didn't identify a strong initial need for it, but perhaps this is such a case? Quick mockup: 
What do you think? |
I'm not really sure the list layout will be ready to be stabilized for 6.5. I'd like feedback from other on this one too.. |
mcsf
reviewed
Jan 10, 2024
packages/edit-site/src/components/sidebar-navigation-screen-templates/index.js
Outdated
Show resolved
Hide resolved
| ( accumulator, template ) => { | ||
| const { | ||
| original_source: originalSource, | ||
| author_text: authorText, |
There was a problem hiding this comment.
Since I'm not familiar enough with the domain: any chance that a plugin template could be missing author_text? If so, should we capture those templates in a special group?
There was a problem hiding this comment.
author_text is always filled with something. The issue is though that for a while(from the old templates list) we were showing information about the author based on the original_source value. Now it seems by just checking one more plugin(Sensei) that plugins could add templates in different ways without filling the original_source property with plugin value. So I'm not really sure what's the way forward here. Maybe it would be useful to find how most plugins add templates and explore our options..
packages/edit-site/src/components/sidebar-navigation-screen-templates/index.js
Outdated
Show resolved
Hide resolved
|
Flaky tests detected in fee398e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7489306204
|
This PR seems mostly ready, other than the question about how to classify templates. I'd ship as it is and explore this separately. We don't need to ship the list view as root everywhere. For example, we could ship grid with patterns as the root page, table with templates (as it is now, as listing), and list view with pages. That way we'd get feedback from every layout. We should evaluate what's missing to make that happen and putting the work hours in those places, if the plan sounds good. |
|
Totally happy to explore the data view stuff separately. I'll push some style tweaks here shortly. |
jameskoster
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #48651
This PR separates the custom templates and the templates added by plugins. Currently the check for plugin templates is based on the
original_sourceproperty(internally checks if there is file and if theoriginhas valueplugin), but it's very possible other plugins add templates differently.I'm not very familiar of all the ways plugins add templates, but in general this can also affect the
authorfilter in templates list. So if this doesn't work well, we'll probably need to see if we can have an API for that - although it seems convoluted at first sight since there are also filters in place for changing/overriding templates.Testing Instructions
Templatesin navigation sidebar and observe the grouping.Screenshots or screencast
Screen.Recording.2024-01-10.at.10.56.19.AM.mov