DataViews: update 'All pages' sidebar heading #56148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
It might be good to update the "Manage your pages" description too. We've stripped language that implies ownership ("your") from other text strings. But before considering alternatives it might be good to answer; is this description useful, or could it be removed? |
|
Size Change: +255 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Nov 15, 2023
At least for this stage, I think it could be completely removed. We could do this change in this PR too. |
|
Agreed, let's remove it for now. It's easy to add back later if we feel a description is required, that's when we can think about something more useful. |
oandregal
changed the title
oandregal
added
[Type] Experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the heading in the page management sidebar.
Why?
"All pages" might be a bit too specific, given it's now possible to view a subset of pages in this view (e.g. Trash). The equivalent view in wp-admin is also titled "Pages".
Before
After
I appreciate this duplicates the heading of the panel parent, so an alternative could be "Manage pages":
Testing Instructions