Improve tooltip for parent blocks on the block toolbar #56146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
requested review from
draganescu,
scruffian,
getdave,
jeryj and
ajlende
|
Size Change: +181 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jeryj
reviewed
Nov 15, 2023
packages/block-editor/src/components/block-parent-selector/index.js
Outdated
Show resolved
Hide resolved
|
Agreed. This is potentially pretty confusin to users. They hover and think "What Group block". But when the context of "Parent" is provided - assuming they understand blocks - then it becomes a lot more obvious what this otherwise cryptic button does 😅 |
jeryj
approved these changes
Nov 15, 2023
|
The e2e tests need fixing after this change, I'll get to this next week |
|
Hi team, maybe we could consider adjusting the copy a bit to include the word block, eg, "Select Parent block - Group" which is more aligned to the language we would use with users in support vs "Select parent group" |
It makes sense to me, the thing is, should we change the naming to the actual block to also include the word block? 
|
That feels like a much larger change. We might want to consider it but not in this PR. |
Would it be better to word it "Select Parent block: Group"? thinking about screen readers here |
MaggieCabrera
requested review from
kevin940726,
Mamaduka,
ajitbohra,
ntwb and
nerrad
as code owners
MaggieCabrera
force-pushed
the
add-improved-parent-tooltip
branch
from
79ddfe3 to
770ed92
Compare
I agree with this! Definitely makes it better for the user |
|
While I do agree the new text clarifies what the parent selector button does, it's worth reminding the tooltip text is the same text that is used to actually label the buttons. When the preference 'Show button text labels' is enabled, this text is visually shown as the button content. Making it so long isn't ideal, see screenshots below. I'd really would like to see any new designs and UI changes take into consideration the 'Show button text labels' preference and treat it like a first class citizen. Ideally, any new design should provide mockups for all the UI states and modes. I will create a separate issue, as this button has a few more problems, unrelated to this PR. WordPress 6.4:
Trunk:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improves the tooltip to make clear we are going to select the parent of the current block
Why?
Having a tooltip that just says "Select Group" can be confusing for new users who are still not used to the editor's UI. There's no way to know the relationship the icon we are clicking has with the current block.
How?
Changed the string
Screenshots or screencast
Before
After