[PoC] Explore options for adding partial syncing of blocks with innerBlock content #56132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n pattern parent attribs
glendaviesnz
added
[Status] In Progress
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
49 tasks
|
Size Change: +167 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7c24dec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6872917422
|
|
There is a problem with this initial PoC for allowing innerBlocks in partial syncing. I am storing the innerBlocks attributes in the parent pattern, which works on the server as we can generate the block content in the editor from this, but for rendering on the frontend we don't have access to the So now looking at other options for saving the innerBlocks changes, including the idea mentioned here. |
|
Closing for now in favour of #56348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently a hard-coded PoC to investigate how feasible it is to serialise innerBlock pattern changes into the parent patterns attributes
Why?
Some work has been done already to allow the partial syncing of pattern content by connecting block attributes, and this may form the basis of any MVP for partial syncing of patterns, but we need to investigate in advance if the approach of storing the instance specific content in the parent pattern block attributes scales to also storing changes to innerBlock content to allow partial syncing of columns, groups, galleries, etc.
How?
Stores a serialised representation of the inner blocks in the parent pattern attributes and update the given block innerblocks with these blocks when loaded.
This is very early stage and is currently just hardcoded in the List block edit method and content needs to be manually pasted into parent pattern attributes. The idea is to use the hard coding to better understand how the flows might work and then this can be abstracted out into the likes of the innerBlocksProps so it can be automatically applied across blocks.
Testing Instructions
Not easily tested yet, more details coming soon ...
Testing Instructions for Keyboard
Screenshots or screencast
sync-inner-blocks.mp4