Plugin upload workflow: Add 300s timeout to svn commit command #55621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
requested review from
fullofcaffeine,
mikachan,
justintadlock and
priethor
|
Looking at #55295 (comment), the recent svn commit commands all took up over 5 minutes (one of them even 10). I'm tempted to increase the timeout to 5 minutes to give a bit more leeway. |
ockham
changed the title
|
I've increased the timeout to 5 minutes. I'd love to give this a shot for 16.9, which @justintadlock is going to release today. Anyone mind giving a quick rubber-stamp ✅ pls? 😊 |
ockham
added
the
Backport to Gutenberg RC
Thank you! Yeah, that's the docs I was perusing as well; I should've added a link!
🤞 |
|
Cherry-picked to the |
ockham
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a
60s300s timeout to the svn commit (and import) commands in the plugin upload workflow.Fixes #55295.
Why?
The Gutenberg release workflow that uploads the plugin to the WordPress.org plugin repositoty frequently experiences a timeout that results in the relevant tag not being created (see here for a list of recent failures), requiring to be created manually instead.
How?
Some investigation seems to have revealed that this timeout might be due to some post-commit hooks running on the server side. To remediate this, this PR adds the
http-timeoutoption to give the svn command more time.Testing Instructions
Hard to test in isolation; I'd suggest we give it a try for the next GB release.