Remove reset button in behaviors, use dropdown option instead #51464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
requested review from
jasmussen,
artemiomorales and
SantosGuillamot
|
Size Change: -521 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
cbravobernal
added
[Block] Image
|
Flaky tests detected in b5bdc9e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5257153122
|
|
Thanks for the PR, as noted in #51357 (comment), I think this gets close. But when you select "Default" in the dropdown, its resting state should say Default, not Lightbox. So we shouldn't have smarts that suggest what is inherited, this needs to be solved separately. There's also #49278 to provide an inheritance interface. |
Done! |
artemiomorales
approved these changes
Jun 14, 2023
We have to update them. As before, they used the selector to check that reading from theme.json was working as expected. |
cbravobernal
commented
Jun 14, 2023
|
|
||
| // The behaviors dropdown should be present and the value should be set to | ||
| // `lightbox`. | ||
| await expect( select ).toHaveValue( 'lightbox' ); |
There was a problem hiding this comment.
This test now makes no sense, as the behavior will be always 'Default' if we don't interact with the selector.
cbravobernal
force-pushed
the
update/move-reset-button-to-default-option
branch
from
8db1d0d to
286541f
Compare
|
Closed as #51357 already has the 'Default' option implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
After a conversation in another draft PR regarding behaviors. I did a proof of concept of having a default option in the dropdown.
Conversation:
#51357 (comment)
Why?
A reset button is not a pattern we are using widely. Also, I still don't know how the interface will be with more than one behavior applied.
How?
Converted the reset button into a dropdown option.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-06-13.at.16.37.22.mov