BorderControl: Improve color code readability in aria-label #51197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +73 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
t-hamano
added
[Focus] Accessibility (a11y)
chad1008
approved these changes
Jun 6, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…s#51197) * BorderControl: Improve color code readability in aria-label * Update changelog * Minor change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #50450
What?
This PR makes the following changes to the
BorderControlcomponent to improve the readability of the aria-label attribute.#000000to#-0-0-0-0-0-0var(--custom)to--customWhy?
I learned that in #50450, where the color name readability was improved, the
aria-labelof the button was updated at the same time. I also learned that theBorderControlcomponent has a similararia-label.I think this component should also have an
aria-labelbased on the same rules.How?
I used the same logic that is used in #50450 to change from the color value to the value to be displayed.
Testing Instructions
colorsin the Controls tab as follows:aria-labelcontaining the appropriate color code when the color is changed.Screenshots or screencast
4670fefd1f34034a580e9bbfdc66f4a0.mp4