Allow nested command loaders within the command center #49658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
mcsf,
jameskoster,
SaxonF,
jasmussen,
richtabor and
ntsekouras
10 tasks
|
Size Change: +463 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b7440a9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4639035887
|
|
Thanks for keeping at this! From the description, the behavior sounds right, but I'm not sure I'm seeing it correctly. I'm seeing this: As far as visuals, I'd love to find some bandwidth to push some changes, but here's some design tweaks I'd love to make: CC: @WordPress/gutenberg-design |
|
@jasmussen it seems like what you're proposing is to not show anything on first load, just the input. That's very different from what the current PR is proposing and might make this PR obsolete (no need for nested pages). I'm fine with any, just let me know what I should be exploring. |
|
That's my instinct yes. I'm thinking of this from the angle that this can become your main "assistant" interface for WordPress, and thus it might be best not to suggest any content until you start searching, making the opportunities seem broader. But I'm happy to hear from @richtabor @SaxonF @jameskoster here. |
I think this is a good baseline, but there could be scenarios where suggestions are helpful. For example if you're editing a template, then we might display a list of recently edited templates as suggestions. This would streamline the flow of navigating between templates which is currently very tedious (as noted in #48443, #48481, and #37001). I suspect this logic could be extrapolated across post types. |
I lean the other direction: to show relevant command suggestions. I'd say it's more helpful to understand the most helpful (and relevant) commands you can execute, than having to type first to see those. The commands could be different for different areas of the Site Editor (and beyond). And perhaps have an element of recently used commands prioritized as well. |
|
closing this as it seems we don't want nesting for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #48457
What?
This explores the idea raised by @jameskoster here #49330 (comment)
Basically, at the root level and if you don't type anything, we don't show pages, templates... until you type. And if you don't type anything, there's an item "search pages" that you can click to go into a nested command search where you can only search for pages.
How?
In terms of APIs, the changes here is that "command loaders" have an isNested flag to define whether or not to enable that behavior and they have to define a custom "placeholder" in this case.
Testing Instructions
1- Enable the command center experiment
2- Open the site editor
3- Click cmd+k
4- See how it feels (related to pages searching)