-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blockGap as a default control on Columns/Column blocks #49526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit strange how the default spacing and the control seem contradictory:
But I suppose that's just #43082 rearing it's head once again...
Yes indeed. :/ |
@richtabor seems it covers #41345 that we can close i guess |
Not quite. That is asking for radius to be added to the individual column blocks. |
hum, i thought you added on columns also. the recurrent need is to build cards, like for services prices (ex: maintenance packs) |
This PR makes blockGap visible right off for Columns/Columns, not radius. The parent Columns block supports radius, but the Column block does not currently. |
I noticed a draft PR by Aaron which has stopped up located here: |
What?
The Group block has padding and blockGap as default controls. The Columns and Column blocks should have those same controls enabled by default, as they are very similar to the Group block.
Why?
Consistency. I would expect the similar blocks to have similar experiences right off.
How?
Adding support via the core/columns block.json.
Testing Instructions
Screenshots or screencast
Before (Column block is the same):
After (Column block is the same):