Proposal: Block copy function #49463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +23 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
gziolo
added
[Feature] Block API
|
I saw #49464 first, and I left a #49464 (comment) that is very close to the API proposed here. The only difference is that I asked whether Regardless, I like the proposal to offer a way to modify the behavior when copying blocks. It's going to be a useful addition. |
|
A transform is an interesting idea! It feels somewhat ergonomic since you can think of it as a transform from a block to "the clipboard". Yes I imagine this should affect both duplicating a block and copying a block to the clipboard. Agree this is a useful proposal especially for extenders. My only hesitation is that if we go with something like #49457 then I'd prefer to have a |
The idea of |
gziolo
added
the
[Type] Technical Prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why
Adds a
copyfunction to the block API that lets blocks customise what happens when the block is duplicated.The motivation for this is to handle cases such as #29693 where a block wants to track a foreign key of some kind.
It's not implemented in this PR, but it also would let us move away from using
__internalWidgetIdwhich is how the widget editor tracks which widget entity should be updated when a block is modified. It's a hack that works because__internalWidgetIddoes not appear in theblock.jsonand so is filtered out when the block is duplicated. Using acopyfunction like above would make this behaviour explicit. (Admittedly it's awkward though because a copy function needs to be declared on every block type.)How to test
View instructions
Paste this into DevTools:
You will then have a Product block that simulates the use case in #29693. Insert the block and notice that a product with ID 1 is created. Duplicate the block and notice that a product with ID 2 is created.