Show list of patterns in template part sidebar in focus mode #47507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Block] Template Part
oandregal
commented
Jan 27, 2023
| @@ -57,6 +57,10 @@ | |||
| min-width: auto; | |||
| } | |||
| } | |||
|
|
|||
| & .block-editor-block-patterns-list__item .block-editor-block-preview__container { | |||
| border: 1px solid $gray-300; | |||
There was a problem hiding this comment.
What would be a good mechanism to highlight patterns when they are not hovered/selected? I found that if the pattern has a white background it does not stand out of its own in the list.
There was a problem hiding this comment.
How about the box-shadow: inset 0 0 0 1px rgba(0, 0, 0, 0.2); that we use in other similar situations (like the color indicators).
There was a problem hiding this comment.
We might consider making a var for that, if we're going to start using it in different places.
oandregal
commented
Jan 27, 2023
| blockPatterns={ blockPatterns } | ||
| shownPatterns={ blockPatterns } | ||
| onClickPattern={ ( pattern ) => { | ||
| console.log( 'pattern clicked ', pattern ); |
There was a problem hiding this comment.
TODO: need to implement actually replacing the template part with the pattern's content.
|
Size Change: +258 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Looking forward to this! Can we also pull over the contents?
|
|
It's been a few months since I worked on this. Going to close it for now and free the issue at #44582 for anyone to take. I may be able to come back at this in a couple of weeks if I manage to wrap up other things in my queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implements #44582
Related #45285
TODO
Testing instructions