Query Loop Block: Use BlockPatternsList component for Query block patterns modal #47366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +47 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6279764. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4027278885
|
apeatling
changed the title
apeatling
changed the title
apeatling
changed the title
|
I think this one is in a good spot now and ready for reviews 👍 |
jameskoster
approved these changes
Jan 25, 2023
ntsekouras
reviewed
Jan 25, 2023
|
@ntsekouras How's this one looking now? I'd love to get this merged before the freeze. Thanks! |
glendaviesnz
approved these changes
Jan 26, 2023
apeatling
force-pushed
the
update/query-block-setup-state
branch
from
a7a901c to
6279764
Compare
|
I've fixed up the e2e tests for the query block pattern insertion to match the new list view. It's now passing. Waiting on this fix to globally broken Gutenberg mobile tests, and will merge after assuming no further feedback. |
Can you wait just a bit until Monday to test/review it? We need to make sure that the previous functionality with previews is preserved. Thank you! |
ntsekouras
reviewed
Jan 30, 2023
There was a problem hiding this comment.
Thanks @apeatling for your work and waiting me to review!
This looks good! I left only a minor comment and the only thing missing here is to style the search input to remain sticky, as we do in the Template Part relevant flows.
|
Thanks @ntsekouras, all fixed up, the search bar is now sticky and visually matches the template part block selection. 👍 |
…Switch the modal to use the BlockPaternsList component to match other pattern selection UI across the editor.
… in query block view.
apeatling
force-pushed
the
update/query-block-setup-state
branch
from
60b5293 to
d8098f8
Compare
|
Going to merge this since it has approval and everything has been fixed up. 👍 |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33202
What?
Replace the
BlockPatternSetupcomponent withBlockPatternsListcomponent to match the experience of selecting patterns in different locations across the editor.Why?
Lots of feedback on the linked issue above. In a nutshell the current carousel style pattern selection feels broken and confusing to users because it is different from anything else.
By moving to
BlockPatternsListwe start the process of consolidating around that component and moving closer to a consistent experience for pattern selection.How?
This PR separates out the pattern selection modal functionality and replaces it to use the
BlockPatternsListcomponent. It also moves the search functionality for filtering pattern data out of the template-part block and into the utils directory where it can be reused.Testing Instructions
Screenshots or screencast
before.mp4
after.mp4