Add E2E tests for 'Import widget area' button #47131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Automated Testing
kevin940726
approved these changes
Jan 13, 2023
|
|
||
| // Verify that the widget area was imported. | ||
| await expect( | ||
| editor.canvas.locator( '[data-type="core/search"]' ) |
There was a problem hiding this comment.
Nit: we can also do editor.getBlocks() and assert the array structure. See this guide for example.
There was a problem hiding this comment.
Thanks! I was actually looking for that helper but couldn't find it.
In any case it doesn't help us here because the blocks we care about are within the template part entity and so not returned by select( 'core/block-editor' ).getBlocks().
talldan
approved these changes
Jan 13, 2023
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 112b8f3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3908162999
|
|
@noisysocks, I've noticed these tests fail a few times. I've no idea why they're not reported as "Flaky Tests", but here're examples: |
juanmaguitar
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds some basic E2E tests for the 'Import widget area' button added in #45509.
Why?
Anything to do with widgets tends to get forgotten about and break 😀. E2E tests, even simple ones, help catch regressions.
Testing Instructions
npm run test:e2e:playwright