Change SpacingSizesControl ARIA from region to group #46530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Package] Components
Mamaduka
requested review from
glendaviesnz and
afercia
and removed request for
ellatrix
|
I will add a changelog entry before merging the fix. |
|
Size Change: +1.63 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
afercia
reviewed
Dec 14, 2022
There was a problem hiding this comment.
Thanks! There's one failing e2e test though, even though it seems unrelated to me. Not sure why it is failing. The code change looks good to me, from an a11y perspecitve.
Note that this change will also fix a bug with navigateRegions. as the incorrect role=region makes this fieldset included in the navigable regions. See #42173 (comment)
Instructions to reproduce are included in a broader issue about navigateRegions, see #46509
mirka
added
[Package] Block editor
mirka
reviewed
Dec 14, 2022
dmsnell
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Change SpacingSizesControl ARIA from region to group * Add changelog entry * Use the correct changelog file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #42173 (comment).
PR updates
SpacingSizesControlARIA from region to group.Why?
Borrowed from #42094
How?
I removed the hardcoded
regionrole since<fieldset>has the implicit role of the group.Testing Instructions
fieldset.component-spacing-sizes-control.Testing Instructions for Keyboard
Props to @afercia