Nav Block: Move color controls to support panel #46049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will mean they appear under the styles tab when the block inspector tabs experiment is enabled.
aaronrobertshaw
added
[Type] Enhancement
|
|
|
Size Change: +76 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
scruffian
approved these changes
Nov 25, 2022
Agreed, this PR only scratches the surface of addressing the Nav block's real needs. I'd expect the next step is to move the text and background colors to use the block supports. The submenu and overlay colors won't be able to be migrated to block supports if kept at the parent nav block level. With this PR, those controls will remain in the color support panel along side the text/background controls whenever they are moved. |
aaronrobertshaw
deleted the
update/move-nav-color-controls-to-styles-tab
branch
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Moves the Navigation block's ad hoc color controls into the color block supports panel.
Why?
How?
Refactors the navigation block colors away from
PanelColorSettingsto its underlyingColorGradientSettingsDropdowncomponent and then renders these to the color block support panel.Testing Instructions
Screenshots or screencast
Screen.Recording.2022-11-25.at.5.49.32.pm.mp4