Add placeholder to Page List block #45871
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are no pages, the Page List block was showing an unnecessary notice when it was a child of a Navigation block. In order to more closely match the rendered front end and reduce clutter, I instead added a placeholder so that users whose intent is to have no pages can see a better representation of their site.
|
|
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @artemiomorales! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
If you allow can i help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses issue #44486 — if a site has no pages, this PR adds a placeholder to the Page List block whenever it is a child of a Navigation block.
Why?
This is to improve the user experience for folks whose main intent is to have no pages; it makes the content in the editor more closely match the published site and reduces clutter.
How?
It adds a placeholder and styling to the Page List block.
Testing Instructions
Screenshots or screencast
Additional Notes