Try nested patterns previews #44773
Closed
Try nested patterns previews #44773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Patterns
|
Size Change: +59 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
ntsekouras
commented
Oct 7, 2022
| const settings = useMemo( | ||
| () => ( { | ||
| ...originalSettings, | ||
| __experimentalBlockPatterns: patterns, |
There was a problem hiding this comment.
We could even pass the parsed patterns only if we are previewing patterns..
|
Closing in favor of: #44784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An attempt to fix: #39732
Alternative to: #42832
Why?
In every block editor instance inside the
BlockListwe useusePreParsePatternsfor better performance to preparse the available patterns. This means we would need to parse them for every block preview that loads a new editor. Previously we were just setting an empty array to the available block patterns and now I'm passing the already parsed patterns, with an additional check not to parse a patterns if contains theblocksproperty.How?
Testing Instructions