[Block Editor]: Better block transforms organization #44072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Blocks
ntsekouras
force-pushed
the
add/better-block-transforms-organization
branch
from
f5e2e93 to
54d4f63
Compare
|
Size Change: +1.09 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Thanks Nik, this seems to be working well.
There are some grey areas, for example I'm not sure Quote should be prioritised more than say, Columns, in the Media and Text transforms:
The separation also feels a bit awkward when Styles are also present:
But we can probably address these details later.
Mamaduka
reviewed
Sep 12, 2022
packages/block-editor/src/components/block-switcher/block-transformations-menu.js
Show resolved
Hide resolved
|
I agree with @jameskoster. Seeing "Quote" as the first transformation option for the Image block doesn't make sense. I think eventually, we would need to handle grouping and priorities on the Transformations API level, and that falls into the future improvement section 😄 |
I think it's weird to see it at all for that one, can we just exclude it? :) |
I'll open a follow up for this. @mtias do you mean exclude the transformation in general or just don't separate it? In general I agree with George that we need to fine tune these in Transformations API. |
|
I think the "Quote" is a recent addition to the global transformations after v2 - #25892. |
|
I mean excluding quote from some of those global transformation cases |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #40208
This PR just prioritizes some 'content' (ex. paragraph -> heading) block transformations in the available transformations list.
Testing Instructions
paragraph, heading, list, quotetransforms, they are prioritized in a separate menu groupScreenshots or screencast