Add border controls to featured image #42765
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to add borders and border-radii to the featured image block:
There is a quirk with this (most basic) implementation. The radius is applied to the
figure
, and so theimg
doesn't receive the properties. This feels a bit unexpected when you visit the frontend and see this:Note how the image corners are overlapping the border.
Despite the fact this is working as intended, we may want to consider adding
overflow: hidden
to any block that also has a border radius, to ensure that its contents respect that radius. E.g.: