BoxControl: Export applyValueToSides util function
#42733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
changed the title
applyValueToSides util function from BoxControlapplyValueToSides util function from BoxControl
|
Size Change: +5 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
This tested well for me @aaronrobertshaw, both as this PR, and also cherry-picked into #42173 and used in the spacing sizes control. |
Thanks for testing. Once I get the chance, I'll publish this ready for review and get the components squad's thoughts. |
aaronrobertshaw
changed the title
applyValueToSides util function from BoxControlapplyValueToSides util function
aaronrobertshaw
added
[Package] Components
This could avoid some code duplication for new components around spacing size presets.
aaronrobertshaw
force-pushed
the
refactor/box-controls-apply-value-to-sides-util
branch
from
8b915f1 to
5bb21ae
Compare
aaronrobertshaw
deleted the
refactor/box-controls-apply-value-to-sides-util
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Makes the
applyValueToSidesfunction within theBoxControla util which can then be exported via the components package.Why?
The new spacing sizes control being created within the block-editor could avoid code duplication if this was available.
Note: The spacing sizes control is very much a bespoke solution to the needs of the editor and as such, wasn't deemed generic enough for the components package itself.
How?
applyValueToSidesfunction out of theBoxControlsidesTesting Instructions
BoxControl's unit tests still passBoxControlis still working correctlyBoxControlbehaves in the editor.