Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing presets: add editor UI support #42173
Spacing presets: add editor UI support #42173
Changes from 80 commits
f979215
f034f2f
b57577f
4e8381a
42615f5
2b9970e
ecb59b0
496dba1
332c3c2
39c4b0c
6409fda
e3b871b
0548311
281c76f
2ad0f96
5bc1046
6cdc706
e998877
7568aaa
71b7fb7
aca422e
b7b8f8d
7592079
448d56a
bc17c58
94e119d
14b7bb5
d3ab731
ae88165
9b496bd
bd60740
cdda2fc
4d900a6
b178c4b
bfd6598
a5bc925
8b78443
b041551
8ae9147
a7aa0d5
7992536
4c866ea
bebffd4
cbe9c5c
7f1cc8e
a31f3b8
b4f664c
563e4bf
5eee65c
a87050d
2b6cade
8f525ee
98118a8
9fbc3b0
87343dd
a4088ea
82c3c3c
2465154
73f96cd
9d390ed
cae7ee2
6ff2352
ca87605
b54163c
deaed6c
b7c53dc
cecbc7f
f11bc9a
bc07d84
038b1c2
f04dff6
7c55b8d
5c34101
cf9822d
bebd991
a71709d
3c64a0c
bce9da8
868f61e
ce380eb
d05bfbf
1abc3a5
aeedc1d
4397dfb
9b73207
1b1f299
68f60bf
cb11f83
884c77a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to throw a fatal in the site editor or a block error in the post editor if spacing sizes are disabled or not available. What should happen for this component if there are no presets? I was wondering if we'd default to just the custom sizes view?
(I noticed this because I forgot to update my
theme.json
file after testing out #43105 🙂)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, let me think about that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for this
role="region"
? It appears this conflicts withuseNavigateRegions
, especially in the Site Editor Will create a new issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't remember the reasoning, so do add a new issue thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Reported in #46509 together with other issues.