-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Show add pattern label when patterns are being prioritised. #40598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
A suggestion for improvement.
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
labels
Apr 25, 2022
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Apr 25, 2022
Size Change: +60 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Apr 26, 2022
jorgefilipecosta
force-pushed
the
fix/show-add-pattern-label
branch
from
April 26, 2022 10:47
5157c12
to
27145a7
Compare
jorgefilipecosta
force-pushed
the
fix/show-add-pattern-label
branch
from
April 26, 2022 10:50
27145a7
to
ab05239
Compare
Mamaduka
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update tests well for me 👍
I cherry picked this change into |
adamziel
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
Needs User Documentation
Needs new user documentation
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows feedback by @annezazu on #40117, and shows "Add pattern" instead of "Add block" when patterns are being prioritized.