-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Block] Transform: Comments-Query-Loop and Post-Comments-Form #40231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in this commit, we have added functionality to support conversion from `comments-query-loop` block to `post-comments-form` and vice-versa.
amustaque97
requested review from
michalczaplinski and
ajitbohra
as code owners
April 11, 2022 15:06
amustaque97
added
[Block] Comments
Affects the Comments Block - formerly known as Comments Query Loop
[Block] Post Comments Form
Affects the Comments Form Block
labels
Apr 11, 2022
Size Change: +97 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
This PR is invalid. Closing this PR in favour of #40223 (comment) |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Comments
Affects the Comments Block - formerly known as Comments Query Loop
[Block] Post Comments Form
Affects the Comments Form Block
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #40223
What?
In the current version of the blocks (
core/comments-query-loop
andpost-comments-form
) doesn't support transform from one block to other. In this PR, I have added a functionality to support block transformation.Why?
How?
Testing Instructions
comments-query-loop
block in your post and click on transforms and applypost-comments-form
.post-comments-form
and apply transformcomments-query-loop
.Screenshots or screencast
Transformation from
comments-query-loop
topost-comments-form
Transformation from
post-comments-form
tocomments-query-loop
.cc @paaljoachim