Adjust the layout of thumbnails in the template part replacement modal #39766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
Size Change: -276 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current two column layout isn't ideal:
The thumbnails are too small to give an effective preview, and the columns make the text difficult to scan.
Until we figure out a more holistic solution (#39308) I've adjusted the modal to display the template parts in a single column:
I think this makes the previews much more effective.
Another option would be to use a popover containing a list of template parts with previews on hover, but this is a much simpler change and seemed worth trying first.
There's also a question of whether we need to distinguish between template parts and patterns with headings, but we can probably address that separately.