Migrate customize widgets editor to use new preferences package #39112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
18 tasks
talldan
changed the title
8 tasks
|
Size Change: -405 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
noisysocks
reviewed
Feb 28, 2022
|
|
||
| .components-popover.customize-widgets-more-menu__content { | ||
| z-index: z-index(".components-popover.customize-widgets-more-menu__content"); | ||
| } |
There was a problem hiding this comment.
I don't understand 😅 Why is all of this CSS no longer needed?
There was a problem hiding this comment.
Aha, the description of #39113 answered my question!
There was a problem hiding this comment.
It hasn't really been needed for a while. It's identical to the css implemented by the base component in the interface package:
https://github.com/WordPress/gutenberg/blob/trunk/packages/interface/src/components/more-menu-dropdown/style.scss
I realised I could've deleted it for edit-widgets too, so I've made a small PR here to do that - #39113
noisysocks
reviewed
Feb 28, 2022
| () => | ||
| !! wp.data | ||
| .dispatch( 'core/preferences' ) | ||
| .toggleFeature( |
noisysocks
reviewed
Feb 28, 2022
| () => | ||
| !! wp.data | ||
| .select( 'core/preferences' ) | ||
| .isFeatureActive( 'core/customize-widgets', 'welcomeGuide' ) |
This was referenced Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses some of #31965, follows #39084
Migrates the customize widgets editor to use the new preferences package (introduced in #38873). Previously it was using interface, but the plan is now to deprecate the preferences APIs in interface in favor of this new package.
The main goal here is that nothing is different from a user perspective.
Testing Instructions
trunkopen the customize widgets editor and dismiss the welcome guideChecklist:
*.native.jsfiles for terms that need renaming or removal).