Page for Posts: Display notice in template panel #38607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
Feb 8, 2022
| 'type' => 'number', | ||
| 'description' => __( 'The ID of the page that should display the latest posts', 'gutenberg' ), | ||
| ) | ||
| ); |
There was a problem hiding this comment.
I noticed that static page settings aren't available when the plugin is deactivated. I think we forgot to expose these settings in REST API for 5.9.
|
Size Change: +214 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
|
How do you feel about keeping the panel, but displaying a message explaining why the template cannot be changed? If we remove the entire panel we also remove the shortcut to edit the current template which seems a bit of a shame. |
Mamaduka
changed the title
|
@jameskoster, I've updated the logic. Let me know if you want to adjust the design.
|
|
Looks like there's a small typo there "connot", otherwise it's good. The "Edit" link looks a bit lost, but we'll most likely address that as a part of #31591 anyway. |
Thanks for catching this. |
|
Nice. Do you think we should remove the dropdown in the quick edit interface as well, or is that something to do separately? |
That probably needs to be fixed in WP core. |
jameskoster
approved these changes
Feb 8, 2022
|
Good catch @Mamaduka. For the person that will work on the fix, we are talking about:
that should be added directly to the settings endpoint. |
This was referenced Jun 24, 2022
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jun 29, 2022
This adds the `show_on_front`, `page_on_front`, and `page_for_posts` options to the settings endpoint that were missed during WP 6.0 backports. Related PR from Gutenberg repository: * [WordPress/gutenberg#38607 #38607 Page for Posts: Display notice in template panel] Props Mamaduka, spacedmonkey, gziolo, jameskoster. See #56058. git-svn-id: https://develop.svn.wordpress.org/trunk@53588 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jun 29, 2022
This adds the `show_on_front`, `page_on_front`, and `page_for_posts` options to the settings endpoint that were missed during WP 6.0 backports. Related PR from Gutenberg repository: * [WordPress/gutenberg#38607 #38607 Page for Posts: Display notice in template panel] Props Mamaduka, spacedmonkey, gziolo, jameskoster. See #56058. Built from https://develop.svn.wordpress.org/trunk@53588 git-svn-id: http://core.svn.wordpress.org/trunk@53176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Jun 29, 2022
This adds the `show_on_front`, `page_on_front`, and `page_for_posts` options to the settings endpoint that were missed during WP 6.0 backports. Related PR from Gutenberg repository: * [WordPress/gutenberg#38607 #38607 Page for Posts: Display notice in template panel] Props Mamaduka, spacedmonkey, gziolo, jameskoster. See #56058. Built from https://develop.svn.wordpress.org/trunk@53588 git-svn-id: https://core.svn.wordpress.org/trunk@53176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jun 29, 2022
This adds the `show_on_front`, `page_on_front`, and `page_for_posts` options to the settings endpoint that were missed during WP 6.0 backports. Related PR from Gutenberg repository: * [WordPress/gutenberg#38607 #38607 Page for Posts: Display notice in template panel] Props Mamaduka, spacedmonkey, gziolo, jameskoster, SergeyBiryukov. Merges [53588] and [53589] to the 6.0 branch. See #56058. git-svn-id: https://develop.svn.wordpress.org/branches/6.0@53590 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Jun 29, 2022
This adds the `show_on_front`, `page_on_front`, and `page_for_posts` options to the settings endpoint that were missed during WP 6.0 backports. Related PR from Gutenberg repository: * [WordPress/gutenberg#38607 #38607 Page for Posts: Display notice in template panel] Props Mamaduka, spacedmonkey, gziolo, jameskoster, SergeyBiryukov. Merges [53588] and [53589] to the 6.0 branch. See #56058. Built from https://develop.svn.wordpress.org/branches/6.0@53590 git-svn-id: http://core.svn.wordpress.org/branches/6.0@53178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Jun 29, 2022
This adds the `show_on_front`, `page_on_front`, and `page_for_posts` options to the settings endpoint that were missed during WP 6.0 backports. Related PR from Gutenberg repository: * [WordPress/gutenberg#38607 #38607 Page for Posts: Display notice in template panel] Props Mamaduka, spacedmonkey, gziolo, jameskoster, SergeyBiryukov. Merges [53588] and [53589] to the 6.0 branch. See #56058. Built from https://develop.svn.wordpress.org/branches/6.0@53590 git-svn-id: https://core.svn.wordpress.org/branches/6.0@53178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
This PR is now backported to 6.0 branch so I'm removing the label. |
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
This adds the `show_on_front`, `page_on_front`, and `page_for_posts` options to the settings endpoint that were missed during WP 6.0 backports. Related PR from Gutenberg repository: * [WordPress/gutenberg#38607 #38607 Page for Posts: Display notice in template panel] Props Mamaduka, spacedmonkey, gziolo, jameskoster, SergeyBiryukov. Merges [53588] and [53589] to the 6.0 branch. See #56058. Built from https://develop.svn.wordpress.org/branches/6.0@53590
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
This adds the `show_on_front`, `page_on_front`, and `page_for_posts` options to the settings endpoint that were missed during WP 6.0 backports. Related PR from Gutenberg repository: * [WordPress/gutenberg#38607 #38607 Page for Posts: Display notice in template panel] Props Mamaduka, spacedmonkey, gziolo, jameskoster. See #56058. Built from https://develop.svn.wordpress.org/trunk@53588
VenusPR
added a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
This adds the `show_on_front`, `page_on_front`, and `page_for_posts` options to the settings endpoint that were missed during WP 6.0 backports. Related PR from Gutenberg repository: * [WordPress/gutenberg#38607 #38607 Page for Posts: Display notice in template panel] Props Mamaduka, spacedmonkey, gziolo, jameskoster, SergeyBiryukov. Merges [53588] and [53589] to the 6.0 branch. See #56058. Built from https://develop.svn.wordpress.org/branches/6.0@53590 git-svn-id: http://core.svn.wordpress.org/branches/6.0@53178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR displays notice inside the "Templates" panel when editing "Page for Posts." Changing the template for this page has no effects;
this also matches logic in Classic Editor.Testing Instructions
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).