Fix/make sure block anchor stays unique #35757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
added
[Type] Enhancement
|
Size Change: +119 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
IMHO we should avoid introducing new hooks in JavaScript whenever possible. It's hard to trace in devtools and makes things implicit. It's sorta like mixins in React which is now deprecated and discouraged. This might be controversial though 😅 . |
kevin940726
reviewed
Oct 19, 2021
| ) { | ||
| // check wether the anchor already ends with a `-${number}` | ||
| const index = block.attributes.anchor.lastIndexOf( '-' ); | ||
| const result = block.attributes.anchor.substring( index + 1 ); |
There was a problem hiding this comment.
I don't think it would work when the anchor has numbers at the end in its original text. For instance, a heading with the anchor id top-100 will be incremented to top-101.
Hey @kevin940726 😀 thanks for the reply here. I wasn't aware of that issue with the hooks. So thanks for letting me know :) Is there an alternate approach that would allow for similar functionality that doesn't have that limitation? I'm just wondering whether there are other approaches to making things extendable 🤔 I agree with the goal to have nice tracing in devtools etc. I also think that software should be extendible and would love to find a way to combine the to :) |
|
I think the 'internal' role for attributes might resolve parts of the issue - #34750. |
I'm not really familiar with this unfortunately. My best guess would be something like |
gziolo
added
the
[Feature] Block API
|
This is something that could be handled by some other proposals that are discussed in other places. There is a related proposal to have an |
|
We recently added automatic anchors for headings, and it includes things like appending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new filter called
blocks.cloneBlockwhich allows you to hook into thecloneBlockfunction and modify the cloned block object.The rationale behind this new filter is the need to keep the anchor attribute unique and when blocks are duplicated that uniqueness is lost. So this filter is now being used to make the anchor unique by adding a
-1(automatically increasing the number if you keep cloning an already cloned block)Closes #35755
How has this been tested?
Locally using the
wp-envUsing the
core/headingblock and duplicating it with no anchor, a simple single word anchor and an anchor that has special characters including-in it.Screenshots
Types of changes
New feature: Make sure anchors stay unique when blocks are duplicated
New API: Introduce
blocks.cloneBlockfilterChecklist:
*.native.jsfiles for terms that need renaming or removal).