Adds auxiliary class names for editor styles in the widgets editor #33388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
adamziel,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: +21 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
desrosj
previously requested changes
Jul 13, 2021
|
Just linking to the original issue: #33370. |
|
I updated it to work with data-* attributes. |
kevin940726
reviewed
Jul 13, 2021
|
I updated this slightly:
Still, I'm not particularly comfortable with including this in 5.8 as it will not receive adequate testing before the final release next week. I'd prefer we add the issue to #33242, think the API through more thoroughly, and include a fix in 5.8.1. What do you think @desrosj? |
noisysocks
added
[Feature] Extensibility
|
Oh, also, I thought about making this change in the Customizer as well but I think it's unnecessary as there are already class names containing the widget area ID in the Customizer. |
|
There will be an unplanned RC4 on Thursday because a few additional regressions were discovered. Does that change your opinion at all @noisysocks? |
|
Aha gotcha. In that case so long as this PR gets some good testing (@talldan? 😀) I'm OK with landing it in RC 4. |
noisysocks
added
the
Backport to WP 6.7 Beta/RC
@noisysocks I'm not sure about this—the widget area panel feels like it should be editor UI and outside the reach of the theme. It's also worth considering that this editor UI might change dependent on the result of #33254, so I think the data attribute should be as close to the content as possible. |
noisysocks
force-pushed
the
try/style-preview-of-widgets
branch
from
f1cec5c to
397218c
Compare
|
@talldan: OK 🙂 I've moved it back to |
talldan
approved these changes
Jul 15, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 15, 2021
…33388) Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Robert Anderson <[email protected]>
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 15, 2021
…33388) Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Robert Anderson <[email protected]>
gwwar
pushed a commit
that referenced
this pull request
Jul 19, 2021
…33388) Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Robert Anderson <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some classes in the widgets editor so that themes can style them individually. If this works probably the same idea in the customizer could work.
How has this been tested?
Tested locally
Screenshots
Widget area classes
Widget preview classes
Types of changes
Non breaking change. Added area name and widget name as classes to widget area block and the legacy widget preview wrapper.