Block Patterns: Remove scope from Query patterns and introduce blockTypes
#30471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Patterns
ntsekouras
requested review from
mcsf,
youknowriad,
mtias,
jameskoster,
kjellr,
jasmussen,
david-szabo97 and
carolinan
ntsekouras
requested review from
ajitbohra,
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +164 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
8 tasks
youknowriad
reviewed
Apr 2, 2021
| onFinish( [ [ 'core/query-loop', {}, blocks ] ] ); | ||
| const clonedBlocks = blocks.map( ( block ) => cloneBlock( block ) ); | ||
| // We need to override the attributes that can be set in the Placeholder. | ||
| Object.assign( clonedBlocks[ 0 ].attributes.query, { |
There was a problem hiding this comment.
do you think we should ensure that there's only one block and that it's a "query"?
There was a problem hiding this comment.
I have addressed this here: 0c7683a.
I now search in top level blocks though for Query and properly handle the needed changes by deep cloning these attributes.
youknowriad
approved these changes
Apr 2, 2021
Not yet, but I'm waiting a bit with all these patterns work that is going on. It will soon change with a unified |
7 tasks
gziolo
changed the title
scope from Query patterns and introduce blockTypesscope from Query patterns and introduce blockTypes
gziolo
added
[Type] Enhancement
|
So if I create a block pattern for a header, do I now include the template part block, just like this includes the query block? |
I haven't checked the nuances about template part yet. I believe it will be handled/explored better on this PR: #29602, that is unblocked now. |
gziolo
added
the
Needs Dev Note
7 tasks
15 tasks
youknowriad
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After various explorations in integrating block patterns with blocks in different contexts (Placeholder, transforms) it seems that a better approach should be to remove the experimental
scope, previously introduced here: #28891The new approach is that every pattern is shown in the
Inserterand if a pattern wants to be used in the other contexts (Placeholder, transforms) should instead declare ablockTypesproperty. This property will be anarraycontaining theblock names.In this PR I'm implementing this change and use it for
Querypatterns that exist in the plugin.Notes
allowed patternsbased on the providedrootClientId.site-editorlots ofappendersare shown. This exists on trunk as well and can be handled maybe separately.InnerBlocksforQueryLoopascontentand now a pattern has theQueryblock itself. What this means is that theQuerypreviews doesn't show just apost. This is good because now a Query pattern could have attributes likelayout:flex(for columns). In addition, we keep the value of posts per page (query.perPage) from Query patterns, so as to preview the pattern as intended, without possible big previews. During insertion we unset theperPagevalue to be set appropriately by Query block.post.Testing Instructions
Queryblock