Block Editor: Show only the allowed patterns from top level blocks #30300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Patterns
|
Size Change: -3 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
I don't think this is necessary. I think we just need to remove the early return from gutenberg/packages/block-editor/src/store/selectors.js Lines 1821 to 1823 in 94db813
|
@david-szabo97 I know but I thought this was part of the perf optimization in your PR. So you think it's okay to remove the early return and get the |
|
Right, it's safe to remove. And yes, that was an optimization but I wasn't aware of |
ntsekouras
changed the title
ntsekouras
force-pushed
the
try/show-allowed-patterns-only
branch
from
7afba8d to
69059f1
Compare
ntsekouras
force-pushed
the
try/show-allowed-patterns-only
branch
from
69059f1 to
7d36548
Compare
david-szabo97
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
This implementation only works for top-level blocks in patterns. If a pattern contains a block deep inside somewhere in its block tree, then it will still show up in the inserter. We need to recursively check for all blocks in the pattern.
For now, I'd go with this implementation and create a follow-up PR that solves this problem in a performance-friendly way. (I'll push a draft PR)
This was referenced Mar 30, 2021
ntsekouras
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially fixes: #23275
Currently patterns don't take into account the
allowed_block_typeswhich can result in showing block patterns in the Inserter and by clicking one the following happens:allowed_block_typesis checked during insertionThis is not a complete solution due to performance implications of pattern parsing for various actions. Ideally we need to find a performant way to recurse through all inner blocks of a block and check if the block is allowed or if is unregistered. For now we check the top level blocks of a pattern.
Testing instructions
allowed_block_typesin phppatternstab and observe the proper results