Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing patterns when idling (performance follow-up for inserting patterns into containers) #29444

Merged
merged 19 commits into from
Mar 24, 2021
Merged

Parsing patterns when idling (performance follow-up for inserting patterns into containers) #29444

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c0edc39
Try parsing patterns when idling
david-szabo97 Mar 1, 2021
4298360
Increase number of patterns
david-szabo97 Mar 2, 2021
c1d85b4
Limit to a single task per idle callback
david-szabo97 Mar 2, 2021
b0b6b43
Update docs
david-szabo97 Mar 2, 2021
39bc7eb
Use requestIdleCallback instead of queue
david-szabo97 Mar 2, 2021
34e4aad
Revert queue
david-szabo97 Mar 2, 2021
ac25ca5
Refactor
david-szabo97 Mar 2, 2021
0e0e2b5
Fix errors
david-szabo97 Mar 4, 2021
4df0a4e
requestIdleCallback and cancelIdleCallback fallback
david-szabo97 Mar 4, 2021
8f07730
Refactor to use getParsedPattern
david-szabo97 Mar 5, 2021
9a200cd
Fix tests
david-szabo97 Mar 5, 2021
a8b3d46
Fix hook rerunning on render
david-szabo97 Mar 9, 2021
b12d4d6
Move hook call into BlockList
david-szabo97 Mar 9, 2021
2945982
Fix deps
david-szabo97 Mar 9, 2021
eb4e1e0
Remove patterns from the block preview context
david-szabo97 Mar 9, 2021
f402bd5
Memoize modified settings
david-szabo97 Mar 9, 2021
fb07d35
Remove debug code snippets
david-szabo97 Mar 10, 2021
1a176d2
Remove unused argument
david-szabo97 Mar 11, 2021
cac8f34
Merge branch 'trunk' into try/parse-patterns-when-idle
david-szabo97 Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/block-editor/src/components/block-preview/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ export function BlockPreview( {
__experimentalLive = false,
__experimentalOnClick,
} ) {
const settings = useSelect(
( select ) => select( blockEditorStore ).getSettings(),
[]
);
const settings = useSelect( ( select ) => {
const _settings = { ...select( blockEditorStore ).getSettings() };
_settings.__experimentalBlockPatterns = [];
return _settings;
}, [] );
youknowriad marked this conversation as resolved.
Show resolved Hide resolved
const renderedBlocks = useMemo( () => castArray( blocks ), [ blocks ] );
if ( ! blocks || blocks.length === 0 ) {
return null;
Expand Down