Button block: add color support via block.json #29382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Block] Buttons
oandregal
commented
Feb 26, 2021
| "reusable": false, | ||
| "__experimentalSelector": ".wp-block-button > a" | ||
| "__experimentalSelector": ".wp-block-button__link" |
There was a problem hiding this comment.
We added the block selector in this PR #25768 and it's used to generate preset classes of this block, if any. I've reduced its specificity to the minimum. cc @youknowriad for thoughts about what selector to use.
Note that if we wanted to use the existing selector we'd need to fix #29381 first.
There was a problem hiding this comment.
I don't have objections here, the simpler the selector the better it seems.
|
Size Change: -819 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
20 tasks
oandregal
force-pushed
the
update/button-color-hook
branch
from
37ce296 to
f6f628e
Compare
youknowriad
approved these changes
Mar 2, 2021
|
Actually, looking at the mobile tests I've noticed we can't remove |
oandregal
force-pushed
the
update/button-color-hook
branch
from
f6f628e to
d7e04d8
Compare
|
I reached out to @chipsnyder and @geriux for feedback on this. |
Hey 👋 I'm going to test this now on mobile and see if it's all working correctly. |
geriux
approved these changes
Mar 3, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #28913
Depends on #29378
This PR removes the ad-hoc color support for the block and uses recently added features to the block support mechanism #28913 that allows us to target elements other than the block wrapper.
How has this been tested?
This PR depends on #29378 so, you'd need to apply those changes to your local branch. For example, check out 29378 locally and then
git merge --squash <local-name-of-29378-branch>.The expected result is that the button without user styles has the colors declared via theme.json and the other button have the user style colors.