WIP - Hybrid themes implementation #29298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +53 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
aristath
commented
Feb 24, 2021
Comment on lines
+7
to
+20
| if ( ! templates.length ) { | ||
| return { | ||
| id: 'index', | ||
| content: { | ||
| raw: '', | ||
| }, | ||
| slug: 'index', | ||
| is_custom: false, | ||
| type: 'wp_template', | ||
| status: 'publish', | ||
| wp_id: null, | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
This part allows the creation of a new template from the dashboard. If the theme doesn't have any templates, there's nothing to fallback to and the site-editor throws errors which prevents the user from creating a template.
This is a simple tweak to allow falling back to something - even if that something is an empty string.
7 tasks
aristath
commented
Feb 26, 2021
| @@ -102,7 +102,7 @@ function gutenberg_menu() { | |||
| * @since 9.4.0 | |||
| */ | |||
| function gutenberg_site_editor_menu() { | |||
| if ( gutenberg_is_fse_theme() ) { | |||
| if ( gutenberg_is_fse_enabled() ) { | |||
There was a problem hiding this comment.
Allow showing the site-editor if the user has opted-in, or we're in an FSE theme.
6 tasks
|
Closing this one. it's too far behind and we already merged #29026 which contained a simpler iteration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an experiment to see if and how we can have hybrid themes. See discussion on #29024
To test, enable a non-FSE theme, then go from the dashboard to Gutenberg > Experiments and enable the FSE experiment. The option only shows when the active theme is not an FSE theme.