-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use display title for template part block type toolbar anchor. #28691
Conversation
Size Change: -2 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
72297e1
to
b1371d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! 👍
I've left a couple of comments and the failing tests are related, so they will need a small update. Other than that it works great!
b1371d0
to
390f010
Compare
789eba6
to
64072fe
Compare
Removes the display of "block type: block label" in favor of label.
f2bbe1c
to
d7825b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 👍
See #28659.
Initial step to improve the toolbar rendering of template part blocks and align them more with recent iterations of reusable blocks. This pull request also removes the display of "block type: block label" in favor of label when used through
<BlockTitle>
across all the places where they are rendered (toolbar, block list view, breadcrumb).