Add a welcome comment to first time contributor PRs #28118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annezazu
added
[Type] Project Management
|
There are some formatting issues with your code. We have a tool which should fix it all automatically provided there are no syntax errors. Give it a try. |
talldan
reviewed
Jan 13, 2021
packages/project-management-automation/lib/tasks/first-time-contributor-label/index.js
Outdated
Show resolved
Hide resolved
talldan
reviewed
Jan 14, 2021
packages/project-management-automation/lib/tasks/first-time-contributor-label/index.js
Show resolved
Hide resolved
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
Okay, there's a chance I messed this up but @noisysocks I think I finally got there with help from Dan! How are we looking now? |
This PR seeks to close out this project automation task by adding in a welcome message to first time contributors encouraging them to join WordPress.org slack and to review the core handbook: #27423 Rather than creating a new file, decided to just latch onto our current setup for adding the first time contributor label. I'm no JS developer so, in a true inception moment, I'll need some "first time contributor" like guidance here to get this right 😄 and, per usual, welcome thoughts on what this message should say. Since we already have a message in place when a PR is merged to encourage folks to connect their WordPress.org profile, I'm leaving that out.
Co-authored-by: Daniel Richards <[email protected]>
…ntributor-label/index.js Co-authored-by: Daniel Richards <[email protected]>
talldan
force-pushed
the
annezazu-patch-1
branch
from
661eaf2 to
3e4855b
Compare
|
Have reported the failing e2e test here - #28825. This branch is completely unrelated as it doesn't touch production code, so I'm approving and merging the PR. |
talldan
approved these changes
Feb 8, 2021
talldan
changed the title
|
Thank you, Dan and Rob, for all the help here. Very much teamwork makes the dream work! |
|
Is this your first non-doc PR? Nice work 🎉 |
annezazu
added a commit
that referenced
this pull request
Feb 12, 2021
After committing this new welcome message #28118, I noticed a few minor spacing issues in the implementation. This PR is a very simple fix to get proper spacing in place!
6 tasks
talldan
pushed a commit
that referenced
this pull request
Feb 12, 2021
* Fix spacing in new contributor welcome message After committing this new welcome message #28118, I noticed a few minor spacing issues in the implementation. This PR is a very simple fix to get proper spacing in place! * update test Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to close out this project automation task by adding in a welcome message to first time contributors encouraging them to join WordPress.org slack and to review the core handbook: #27423 Rather than creating a new file, decided to just latch onto our current setup for adding the first time contributor label.
I'm no JS developer so, in a true inception moment, I'll need some "first time contributor" like guidance here to get this right 😄 and, per usual, welcome thoughts on what this message should say. Since we already have a message in place when a PR is merged to encourage folks to connect their WordPress.org profile, I'm leaving that out.
Types of changes
This is a new feature that adds a welcome message in GitHub to new contributors.
Checklist: