Use the inserter panel for the edit-site screen #22413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Full Site Editing
[Type] Experimental
|
Size Change: +274 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
53 tasks
youknowriad
changed the title
epiqueras
requested changes
May 18, 2020
| showInserterHelpPanel | ||
| toggleProps={ inserterToggleProps } | ||
| <Button | ||
| className="edit-post-header-toolbar__inserter-toggle" |
There was a problem hiding this comment.
We need to have an edit-site class here. I wonder if it makes sense for these styles to live in a shared package instead?
There was a problem hiding this comment.
What package. At the moment I'm not even certain if at then end of the day, we'd just use edit-post with extensions as edit-site. So I'd prefer to avoid early abstractions like that.
youknowriad
force-pushed
the
update/edit-site-inserter-panel
branch
from
7d3f0e8 to
e44e477
Compare
epiqueras
requested changes
May 19, 2020
| showInserterHelpPanel | ||
| toggleProps={ inserterToggleProps } | ||
| <Button | ||
| className="edit-site-header-toolbar__inserter-toggle" |
There was a problem hiding this comment.
I can't find any CSS rules targetting this selector.
There was a problem hiding this comment.
you're right, it's useless.
epiqueras
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #21245 #20791
Update the edit-site screen to use the inserter panel which