-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of the new Zoom Out button breaks UI layout on smaller browser widths #67069
Comments
Hi @maddisondesigns, Could you clarify how you’re keeping the sidebar open while working in Gutenberg? A screen recording would be incredibly helpful to understand your setup better. I noticed that this was tagged for the Classic Editor. If the issue is specific to that, it might be more appropriate to report it on WordPress Trac instead. Let me know if you need assistance with that! Thanks for bringing this up—it’s always great to dig into these details together. |
Hey @maddisondesigns , Thank you for bringing up this issue. I was able to reproduce it in Firefox, though it does not appear to occur in Chrome. The issue seems to specifically affect smaller browser widths. 2024-11-18.15-09-32.mp4Environment
|
@Mayank-Tripathi32 Which sidebar are you referring to? The main WordPress Menu sidebar or the Page/Block settings Sidebar? Also, it wasn't tagged for the Classic Editor, it's tagged as using a Classic Theme (Twenty Twenty-One). The WordPress Menu sidebar is open because I dont have FullScreen mode turned on. Screencast: https://share.zight.com/bLuvW6q7 |
Hi @maddisondesigns, Apologies for the confusion earlier! I’ve been able to replicate the issue in Firefox now and am currently working on a potential fix. I’ll share updates as soon as I have something concrete. Thank you for your patience and for flagging this! 😊 |
@SainathPoojary Have just tried in Brave (which uses the Chrome engine), and yep, it appears to display fine in that browser. And yep, as you can see in my short screencast above, and mentioned in my original post, the issue is on smaller browser widths. Any widths smaller than 1250px and the text starts to hide behind the document bar. |
Hi, I was able to pinpoint issue into the following code. The .editor-header {
display: grid;
grid-auto-flow: row;
grid-template: auto / $header-height minmax(0, max-content) minmax(min-content, 1fr) $header-height;
&:has(> .editor-header__center) {
grid-template: auto / $header-height min-content 1fr min-content $header-height;
@include break-medium {
grid-template: auto / $header-height minmax(min-content, 1fr) 2fr minmax(min-content, 1fr) $header-height;
}
}
} Removing the @include break-medium resolves the issue but makes it not centered for larger viewports, I am not sure why it causes problems in Firefox. I will investigate further and open up the PR. Update:
Following spacing works perfectly. |
There is a ticket for this also in Core Trac: https://core.trac.wordpress.org/ticket/62204 |
A similar report on Trac 62537 shows multiple icons from plugins, and Trac 62535 might also be related. Please test with plugin-added icons and with languages whose translation of "Save draft" is wider (for example, French has "Enregistrer le brouillon"). |
Thank you, @sabernhardt, for pointing this out. I'll take a closer look. I believe I’ve mostly fixed the Firefox layout issue, but it’s possible that Trac 62537 is still affected. I’ll investigate further and provide an update soon. |
Hey, It will also break for different language translations, should I open a new issue for this? ps: adding auto seems to fix this but middle element isn't centered anymore, so could consider it if no alternatives ig |
created new issue for this #68065 |
Description
When the browser width is reduced to around 1200px wide the
Save Draft
text starts appearing behind the document barStep-by-step reproduction instructions
Save Draft
text appearing behind the document bar as per screenshot aboveScreenshots, screen recording, code snippet
No response
Environment info
WP 6.7
Firefox 132.0.2
macOS Sonoma 14.6.1
No plugins
Twenty Twenty-One
Please confirm that you have searched existing issues in the repo.
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Please confirm which theme type you used for testing.
The text was updated successfully, but these errors were encountered: