-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Loop block: improve setup state #33202
Comments
The checkboxes are way easier to understand, and seem like they provide more flexibility to choose elements. Love it. |
There is an issue for this here: #31593. |
Wanted to share feedback here from the nineteenth call for testing for the FSE Outreach Program:
Here's the current state in Gutenberg 14.8.4 for context: |
What about using a pared down version of the pattern explorer in place of the carousel view? This would match the experience with selecting patterns elsewhere. To start it could remove the category and search sidebar that you get in the explorer, keeping things simple: I think ideally over time the pattern selection and insertion experience becomes synced and consistent regardless of where you're triggering it from. |
I want to say we started with something similar to this but let me cc @jameskoster into this as this also ties into the broader issue around these modals #39308 |
+1 on establishing a consistent way of selecting/replacing patterns of any type. I like @jameskoster solution here which looks close to @apeatling proposal above. We can use left sidebar to introduce filtering in future if needed. |
I left some feedback on some of the problems with the carousel mode in a separate issue, I'll copy it here to consolidate, but I think it was mostly mentioned elsewhere:
|
Talking with @jameskoster I'm going to look at using the same flow as adding a new empty template part block: By using this in two places we can start to consolidate and then look to improve further around the new design work in #39308 (comment) |
I'd like to propose a couple of small improvements to the current placeholder of the block.
The first one is adding the title of the variation in the carousel view. While I don't think it's a critical improvement, I think it's important that the two views (carousel and grid) are consistent.
I think there are two possible positions. The left one is probably more useful because it allows users to connect the title with the variation right away.
My other proposal would be to improve the "Star blank" placeholder with two things:
The form is less confusing than the list of icons with labels (it doesn't require you to scan the full list to see if the combination you want exists) and gives a little bit of extra control without complicating the interface too much.
The text was updated successfully, but these errors were encountered: