Skip to content

Commit

Permalink
Query view.js: Code quality (#54982)
Browse files Browse the repository at this point in the history
Fixing a typo and improving some JS comments
  • Loading branch information
them-es authored Oct 3, 2023
1 parent 140d04e commit 8b264bf
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions packages/block-library/src/query/view.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ const isValidLink = ( ref ) =>
ref.origin === window.location.origin;

const isValidEvent = ( event ) =>
event.button === 0 && // left clicks only
! event.metaKey && // open in new tab (mac)
! event.ctrlKey && // open in new tab (windows)
! event.altKey && // download
event.button === 0 && // Left clicks only.
! event.metaKey && // Open in new tab (Mac).
! event.ctrlKey && // Open in new tab (Windows).
! event.altKey && // Download.
! event.shiftKey &&
! event.defaultPrevented;

Expand All @@ -39,7 +39,7 @@ store( {
const id = ref.closest( '[data-wp-navigation-id]' )
.dataset.wpNavigationId;

// Don't announce the navigation immediately, wait 300 ms.
// Don't announce the navigation immediately, wait 400 ms.
const timeout = setTimeout( () => {
context.core.query.message =
context.core.query.loadingText;
Expand Down

1 comment on commit 8b264bf

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 8b264bf.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6396067318
📝 Reported issues:

Please sign in to comment.