Consistent default typography controls across blocks (#55208)

* remove default controls for heading * Standardize default controls for other content blocks * Update e2e tests --------- Co-authored-by: George Mamadashvili <[email protected]>
WordPress · Dec 1, 2023 · 4d1d4f8 · 4d1d4f8
1 parent c2dfa29
commit 4d1d4f8
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 20 deletions.
diff --git a/packages/block-library/src/heading/block.json b/packages/block-library/src/heading/block.json
@@ -57,9 +57,7 @@
 			"__experimentalTextDecoration": true,
 			"__experimentalWritingMode": true,
 			"__experimentalDefaultControls": {
-				"fontSize": true,
-				"fontAppearance": true,
-				"textTransform": true
+				"fontSize": true
 			}
 		},
 		"__unstablePasteTextInline": true,

diff --git a/packages/block-library/src/post-title/block.json b/packages/block-library/src/post-title/block.json
@@ -55,9 +55,7 @@
 			"__experimentalTextDecoration": true,
 			"__experimentalLetterSpacing": true,
 			"__experimentalDefaultControls": {
-				"fontSize": true,
-				"fontAppearance": true,
-				"textTransform": true
+				"fontSize": true
 			}
 		}
 	},

diff --git a/packages/block-library/src/pullquote/block.json b/packages/block-library/src/pullquote/block.json
@@ -46,8 +46,7 @@
 			"__experimentalTextDecoration": true,
 			"__experimentalLetterSpacing": true,
 			"__experimentalDefaultControls": {
-				"fontSize": true,
-				"fontAppearance": true
+				"fontSize": true
 			}
 		},
 		"__experimentalBorder": {

diff --git a/packages/block-library/src/query-title/block.json b/packages/block-library/src/query-title/block.json
@@ -50,9 +50,7 @@
 			"__experimentalTextTransform": true,
 			"__experimentalTextDecoration": true,
 			"__experimentalDefaultControls": {
-				"fontSize": true,
-				"fontAppearance": true,
-				"textTransform": true
+				"fontSize": true
 			}
 		}
 	},

diff --git a/packages/block-library/src/quote/block.json b/packages/block-library/src/quote/block.json
@@ -42,8 +42,7 @@
 			"__experimentalTextDecoration": true,
 			"__experimentalLetterSpacing": true,
 			"__experimentalDefaultControls": {
-				"fontSize": true,
-				"fontAppearance": true
+				"fontSize": true
 			}
 		},
 		"color": {

diff --git a/packages/block-library/src/site-title/block.json b/packages/block-library/src/site-title/block.json
@@ -56,11 +56,7 @@
 			"__experimentalFontWeight": true,
 			"__experimentalLetterSpacing": true,
 			"__experimentalDefaultControls": {
-				"fontSize": true,
-				"lineHeight": true,
-				"fontAppearance": true,
-				"letterSpacing": true,
-				"textTransform": true
+				"fontSize": true
 			}
 		}
 	},

diff --git a/packages/block-library/src/verse/block.json b/packages/block-library/src/verse/block.json
@@ -40,8 +40,7 @@
 			"__experimentalTextTransform": true,
 			"__experimentalTextDecoration": true,
 			"__experimentalDefaultControls": {
-				"fontSize": true,
-				"fontAppearance": true
+				"fontSize": true
 			}
 		},
 		"spacing": {

diff --git a/test/e2e/specs/site-editor/push-to-global-styles.spec.js b/test/e2e/specs/site-editor/push-to-global-styles.spec.js
@@ -53,6 +53,16 @@ test.describe( 'Push to Global Styles button', () => {
 			} )
 		).toBeDisabled();
 
+		// Enable letter case.
+		const typographyOptions = page.getByRole( 'button', {
+			name: 'Typography options',
+		} );
+		await typographyOptions.click();
+		await page
+			.getByRole( 'menuitemcheckbox', { name: 'Letter case' } )
+			.click();
+		await typographyOptions.click();
+
 		// Make the Heading block uppercase
 		await page.getByRole( 'button', { name: 'Uppercase' } ).click();