This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Fix frontedAttributes not using the resolved attribute values
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "editor.defaultFormatter": "dprint.dprint" | |||
There was a problem hiding this comment.
I think it's not the best practice in a large repo to add this file, but I think for convenience and to force people to help test dprint we should add it.
There was a problem hiding this comment.
Good idea. Thanks, Michal 🙂
| @@ -63,7 +63,7 @@ export const hydrate = (container, element, hydrationOptions) => { | |||
| break; // break loop on first match | |||
| } | |||
| }); | |||
| io.observe(element.children[0]); | |||
| io.observe(container.children[0]); | |||
There was a problem hiding this comment.
I've re-ordered the arguments to match the signature of ReactDOM.hydrate()
luisherranz
approved these changes
May 19, 2022
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "editor.defaultFormatter": "dprint.dprint" | |||
There was a problem hiding this comment.
Good idea. Thanks, Michal 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've introduced a bug in #15!
The
frontedAttributesshould be an object with the values of the attributes. Instead, it was an object with the rawattributesfrom theblock.jsonwhich is not what we really want!I've also started using
dprintand it seems to work fine with the extension, but I notice that the formatting is a little different which is why there are some formatting-related changes in this PR.Also, updated
package-jsonso that we get the latestdprintwhich can use a local npm installation ofdprint.