Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve API and Structure of Components #129

Merged
merged 40 commits into from
Oct 16, 2024
Merged

Improve API and Structure of Components #129

merged 40 commits into from
Oct 16, 2024

Conversation

WolfyScript
Copy link
Owner

  • Clear separation between NativeComponents and Component Setup Functions

    • Only NativeComponents are actual components present in the model graph
    • Component Setup Functions defined via API to structure and group UI. They only run once and set up the reactive system around NativeComponents

  • Simplify the platform implementations

    • Keep styles separate from components
    • Keep renderer separate from the reactive graph

@WolfyScript
Improve the structure of components
2319997 
* Clear separation between NativeComponents and Component Setup Functions
* Better API for components
  * Move things like style and icon settings out of the scope into the properties
  * Reserve receiver functions for component scope specific settings (e.g. Router { <routes> }). Buttons do not need any children for example
@WolfyScript WolfyScript self-assigned this Aug 30, 2024
@WolfyScript WolfyScript added the enhancement New feature or request label Aug 30, 2024
@WolfyScript
Change BuildContext to keep track of ancestor components
01bebfb
@WolfyScript
Move component setup to setup functions
48487fe 
* NativeComponents no longer have a method to add them to the graph
* setup functions create the signals and effects and construct the initial component graph
@WolfyScript
Use listener pattern for ModelGraph
550938c 
* Add API for ModelGraph
@WolfyScript
Remove UpdateInformation
32c5179
@WolfyScript
Trying out delegates to easily notify model about updates
a4b6bd8
@WolfyScript
Use resolvers setter instead of function
464a0bb
@WolfyScript
Implement show component
cb2c09c
@WolfyScript
Add doc to show component
92e4365
@WolfyScript
Implement interval api for components
33fb4ab
@WolfyScript
Change slot value property to function
ee1a4f1
@WolfyScript
Improve Signals, Memos, etc. to better handle nullable values
718ea7c 
* Memos now also require an initial value
@WolfyScript
Remove BuildContext & Propagate parents through ComponentScopes
0c1f052
@WolfyScript
Move inventory ui related implementations
a605856
@WolfyScript
Implement Sponge ui rendering & reduce platform specific code
f55fb1e
@WolfyScript
Separate Renderer & InteractionHandler from ViewRuntime
55d37ed 
Renderers and InteractionHandlers can now be picked upon creation of the ViewRuntime, making it easier to compose different kinds of runtimes when another Renderer/InteractionHandler type is available
@WolfyScript
Add missing repo
8f3975f
@WolfyScript
Fix missing generic parameters
630604e
@WolfyScript
Register sponge component renderers
6d34495
@WolfyScript
Remove Renderers dependency on InteractionHandler
28c10c5 
This separates them even further, so they should work independent of each other in theory
@WolfyScript
Check if holder of inventory is same runtime
126a4a4
@WolfyScript
Add Sponge test/example plugin
775b9a5
@WolfyScript
Shade required dependencies for sponge-plugin
eaf7a66
@WolfyScript
Add command to open gui
9737576
@WolfyScript
Register component renderers via key instead of class
c1e84f7
@WolfyScript
Implement sponge interaction handlers
3210cbd 
* Use native sponge events for component interaction handlers instead of a weird wrapper
@WolfyScript
Run effects after inventory interaction
a319279
@WolfyScript
Actually clear slots when removing components
5b445b2
@WolfyScript WolfyScript marked this pull request as ready for review September 14, 2024 16:59
@WolfyScript WolfyScript merged commit 6265434 into master Oct 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WolfyScript WolfyScript

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WolfyScript