-
Notifications
You must be signed in to change notification settings - Fork 10
Spigot Impl. of the ItemStackConfig & Better ItemReferences #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WolfyScript
wants to merge
51
commits into
v5.0.0
Choose a base branch
from
better-itemstack-config
base: v5.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/com/wolfyscript/utilities/bukkit/WolfyCoreBukkit.java # core/src/main/java/me/wolfyscript/utilities/registry/Registries.java
* Updated #constructParser to create default and custom parser
…new ItemReference on deserialization
* Old methods are kept for backwards compatibility, but are deprecated and may return different values than before.
# Conflicts: # core/src/main/java/com/wolfyscript/utilities/bukkit/WolfyCoreBukkit.java # core/src/main/java/com/wolfyscript/utilities/bukkit/registry/BukkitRegistries.java # core/src/main/java/com/wolfyscript/utilities/bukkit/registry/RegistryCustomItem.java # core/src/main/java/com/wolfyscript/utilities/bukkit/registry/RegistryItemReferences.java # core/src/main/java/com/wolfyscript/utilities/bukkit/world/items/BukkitItemStackConfig.java # core/src/main/java/com/wolfyscript/utilities/bukkit/world/items/CustomItem.java # core/src/main/java/com/wolfyscript/utilities/bukkit/world/items/reference/BackwardsWrapperReference.java # core/src/main/java/com/wolfyscript/utilities/bukkit/world/items/reference/BukkitItemReference.java # core/src/main/java/com/wolfyscript/utilities/bukkit/world/items/reference/ItemRefCompDeserializer.java # core/src/main/java/com/wolfyscript/utilities/bukkit/world/items/reference/ItemReference.java # core/src/main/java/com/wolfyscript/utilities/bukkit/world/items/reference/ItemReferenceParserSettings.java # core/src/main/java/com/wolfyscript/utilities/bukkit/world/items/reference/SimpleBukkitItemReference.java # core/src/main/java/com/wolfyscript/utilities/bukkit/world/items/reference/WolfyUtilsItemReference.java
… and references. * The References require a parser class to be parsed from ItemStacks. The static method to parse from stacks is no longer available.
….Creator.AbstractParser
* It can apply the NBTConfigs to the ItemStack. * Reading and saving the NBT from the ItemStack is still wip.
* This makes it possible to access context values inside the config and configure complex item NBT.
* BackwardsWrapperReference * BukkitItemReference
* Use Paper Stack display options using MiniMessage * No longer read NBTTags that are already handled by the common config settings.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First test implementation of the cross-platform ItemStackConfig for Spigot.
This is not at all functional yet!
Better ItemReferences to replace the old APIReferences.
These new ItemReferences require less boilerplate code to be created and registered.