Testing fix for deadlock during paclet check in GitHub actions#206
Open
rhennigan wants to merge 3 commits into
Open
Testing fix for deadlock during paclet check in GitHub actions#206rhennigan wants to merge 3 commits into
rhennigan wants to merge 3 commits into
Conversation
…adlocks during paclet check
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CI/paclet build scripts to avoid a deadlock seen during GitHub Actions paclet checks, primarily by reducing/reshaping Front End usage during automated runs.
Changes:
- Removed
UsingFrontEndwrapping from GitHub Actions test execution inScripts/TestPaclet.wls. - Added a new
Scripts/UnformatFiles.wlsstep and a corresponding--unformat/-uflag inScripts/BuildPaclet.wls(defaulting on in CI) to re-export notebooks before checks/build steps. - Wrapped
CreatePreferencesContent[]withUsingFrontEndand applied minor whitespace/comment formatting tweaks; updated cspell wordlist.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Scripts/UnformatFiles.wls | New script to re-export notebooks under FE with specific FE session settings prior to CI checks. |
| Scripts/TestPaclet.wls | Removes FE usage in GitHub Actions test path to reduce deadlock risk. |
| Scripts/BuildPaclet.wls | Adds --unformat option, runs the unformat step in CI, and standardizes CI detection via $inCICD. |
| Kernel/PreferencesContent.wl | Ensures preferences UI construction runs under UsingFrontEnd; formatting-only adjustments nearby. |
| .cspell.json | Adds “Unformatting” to the dictionary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.