Enabling backup when the ClientSideEncryption is enabled #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason A. Donenfeld <[email protected]>
Signed-off-by: Rob Emery <[email protected]>
enforced as Android 5 just ignores it Signed-off-by: Rob Emery <[email protected]>
zx2c4-bot
force-pushed
the
master
branch
3 times, most recently
from
91cdc96 to
57bd0ec
Compare
zx2c4
reviewed
May 7, 2025
| <?xml version="1.0" encoding="utf-8"?> | ||
| <full-backup-content> | ||
| <include domain="sharedpref" path="." requireFlags="clientSideEncryption" /> | ||
| <include domain="database" path="." requireFlags="clientSideEncryption" /> |
zx2c4
reviewed
May 7, 2025
| @@ -21,7 +21,7 @@ android { | |||
| namespace = pkg | |||
| defaultConfig { | |||
| applicationId = pkg | |||
| minSdk = 21 | |||
| minSdk = 23 | |||
There was a problem hiding this comment.
Is this necessary? Can't these just be conditioned on having the right sdk value? clientSideEncryption, for example, is only available in API 28 and higher.
zx2c4
reviewed
May 7, 2025
| <full-backup-content> | ||
| <include domain="sharedpref" path="." requireFlags="clientSideEncryption" /> | ||
| <include domain="database" path="." requireFlags="clientSideEncryption" /> | ||
| <include domain="file" path="." requireFlags="clientSideEncryption" /> |
There was a problem hiding this comment.
Do we also want the deviceToDeviceTransfer requirement?
zx2c4
reviewed
May 7, 2025
| @@ -37,7 +37,8 @@ | |||
|
|
|||
| <application | |||
| android:name=".Application" | |||
| android:allowBackup="false" | |||
| android:allowBackup="true" | |||
| android:fullBackupContent="@xml/backup" | |||
There was a problem hiding this comment.
This only works for API ≤30. For API ≥31, you need android:dataExtractionRules and a different file. See https://developer.android.com/identity/data/autobackup for details.
|
I left some comments on here. How safe is this clientSideEncryption and deviceToDeviceTransfer business? Can these be abused? Is this something we want on by default? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can safely permit WireGuard to be backed up if we enforce the clientSideEncryption requirement and maintain the users privacy on the keys.